Work towards supporting tree node filtering in MSTest #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Feb 3, 2025
| // NOTE: Implementation is borrowed from VSTest | ||
| // MSTest relies on this method existing and access it through reflection: https://github.com/microsoft/testfx/blob/main/src/Adapter/MSTest.TestAdapter/TestMethodFilter.cs#L115 | ||
| public ITestCaseFilterExpression? GetTestCaseFilter( | ||
| IEnumerable<string>? supportedProperties, | ||
| Func<string, TestProperty?> propertyProvider) | ||
| { | ||
| if (TreeNodeFilter is not null) |
There was a problem hiding this comment.
TODO: We can either say that VSTest's filter and tree node filter are not supported together at the same time, or we can create a new CompoundTestCaseFilterExpression which takes the two ITestCaseFilterExpression and does && between them.
Putting this comment as a reminder, but let's first finalize something that works first then get back to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4293